Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect Feature-Policy/wake-lock to screen-wake-lock #4873

Merged

Conversation

sideshowbarker
Copy link
Collaborator

@sideshowbarker sideshowbarker commented May 10, 2021

There is no “wake-lock” feature-controlled-policy defined in any current spec, and no “wake-lock” feature-controlled-policy was ever implemented in any browser. It’s instead called screen-wake-lock.

So this change redirects the Feature-Policy/wake-lock article to the Feature-Policy/screen-wake-lock article.

Related BCD change: mdn/browser-compat-data#10421

@sideshowbarker sideshowbarker requested review from a team as code owners May 10, 2021 11:41
@sideshowbarker sideshowbarker requested review from chrisdavidmills and removed request for a team May 10, 2021 11:41
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2021

Preview URLs

Flaws

URL: /en-US/docs/Web/HTTP/Headers/Feature-Policy
Title: Feature-Policy
on GitHub
Flaw count: 3

  • macros:
    • /en-US/docs/Web/API/Navigator/requestMIDIAccess does not exist
  • broken_links:
    • Can't resolve /en-US/docs/Web/API/Web_MIDI_API
  • bad_bcd_links:
    • no explanation!

URL: /en-US/docs/Web/HTTP/Headers/Feature-Policy/screen-wake-lock
Title: Feature-Policy: screen-wake-lock
on GitHub
Flaw count: 1

  • bad_bcd_queries:
    • No BCD data for query: http.headers.Feature-Policy.screen-wake-lock

External URLs

URL: /en-US/docs/Web/HTTP/Headers/Feature-Policy
Title: Feature-Policy
on GitHub


URL: /en-US/docs/Web/HTTP/Headers/Feature-Policy/screen-wake-lock
Title: Feature-Policy: screen-wake-lock
on GitHub

No new external URLs

(this comment was updated 2021-05-10 11:55:42.629586)

sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request May 10, 2021
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change renames http.headers.feature-policy.wake-lock to
http.headers.feature-policy.screen-wake-lock.

The change also adds a spec URL for the feature.

Related MDN change: mdn/content#4873
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/pp-wake-lock-redirect-to-screen-wake-lock branch from e9167e2 to 65bb2af Compare May 10, 2021 11:48
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change redirects the Feature-Policy/wake-lock article to the
Feature-Policy/screen-wake-lock article.

Related BCD change: mdn/browser-compat-data#10421
@sideshowbarker sideshowbarker force-pushed the sideshowbarker/pp-wake-lock-redirect-to-screen-wake-lock branch from 65bb2af to f175920 Compare May 10, 2021 11:53
sideshowbarker added a commit to w3c/browser-compat-data that referenced this pull request May 10, 2021
There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change renames http.headers.feature-policy.wake-lock to
http.headers.feature-policy.screen-wake-lock.

The change also adds a spec URL for the feature.

Related MDN change: mdn/content#4873
@Elchi3 Elchi3 merged commit a390050 into main May 19, 2021
@Elchi3 Elchi3 deleted the sideshowbarker/pp-wake-lock-redirect-to-screen-wake-lock branch May 19, 2021 13:40
foolip pushed a commit to mdn/browser-compat-data that referenced this pull request May 20, 2021
)

There is no “wake-lock” feature-controlled-policy defined in any current
spec, and no “wake-lock” feature-controlled-policy was ever implemented
in any browser. It’s instead called “screen-wake-lock”.

So this change renames http.headers.feature-policy.wake-lock to
http.headers.feature-policy.screen-wake-lock.

The change also adds a spec URL for the feature.

Related MDN change: mdn/content#4873

Co-authored-by: Florian Scholz <fs@florianscholz.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants